Update Apple Upcoming Requirements #1142
Conversation
Privacy Manifests: https://developer.apple.com/support/third-party-SDK-requirements/ App Store Connect upload requirement https://developer.apple.com/news/?id=fxu2qp7b
Code cleanup
|
Great! It seems that the empty privacy manifest might be unnecessary. What do you think?
|
@elmetal Thanks for bringing this up. It's an interesting point regarding the necessity of the PrivacyManifest.xcprivacy file, especially, I referred Snapkit listed under https://developer.apple.com/support/third-party-SDK-requirements
With empty privacy manifest
We can avoid unnecessary app rejection or the need to appeal a review by simply not adding this. |
| s.watchos.deployment_target = '10.0' | ||
| s.ios.deployment_target = '17.0' | ||
| s.osx.deployment_target = '12.0' | ||
| s.tvos.deployment_target = '17.0' |
There was a problem hiding this comment.
I assume "must be built with Xcode 15 for iOS 17..." does not mean we should set the deployment target to iOS 17 as it will break most existing clients of the library who still might support earlier iOS versions.
If you check https://developer.apple.com/ios/submit/ it just says "must be built with a minimum of Xcode 15 and the iOS 17 SDK." There is no limitation to the deployment target it just has to be built with Xcode 15 and the latest SDK which makes sense.
I believe we will have to revert most of the introduced limitations in this pull request.
There was a problem hiding this comment.
@tristanhimmelman
This is correct. Can you revert this code so the library can support old iOS versions? Thank you
There was a problem hiding this comment.
@mvn-thanhnguyen4-dn that makes sense. Can you submit a PR please
There was a problem hiding this comment.
@tristanhimmelman
Please review this PR. Thank you
#1146
Privacy Manifests:
https://developer.apple.com/support/third-party-SDK-requirements/
App Store Connect upload requirement
https://developer.apple.com/news/?id=fxu2qp7b
Why
What
Test Case
