Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Default nil token (fix #75) #76

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Default nil token (fix #75) #76

merged 2 commits into from
Jan 20, 2021

Conversation

tristanmorgan
Copy link
Owner

Description

Sets a default value of nil for the token param to verify_cred. adds a little more test coverage.

Fixes #75

Did you run the Tests?

  • Rubocop
  • Rspec
  • Filemode
  • Yard

carljavier
carljavier approved these changes Jan 20, 2021
View reviewed changes
Copy link

@carljavier carljavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tristanmorgan tristanmorgan merged commit 22cef63 into main Jan 20, 2021
@tristanmorgan tristanmorgan deleted the default-nil-token branch January 20, 2021 00:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@carljavier carljavier carljavier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update command failed.
2 participants
@tristanmorgan @carljavier