Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(Auto)Complete rewrite #79

Merged
merged 2 commits into from
May 21, 2021
Merged

(Auto)Complete rewrite #79

merged 2 commits into from
May 21, 2021

Conversation

tristanmorgan
Copy link
Owner

Description

First I'm removing some redundant aliases and the "--role" parameter in preparation for using symbols in autocomplete. This makes the code clearer (no magic numbers like 40 equals console paths) and cover some more edge cases.

Did you run the Tests?

  • Rubocop
  • Rspec
  • Filemode
  • Yard

Copy link

@wadefrancis wadefrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tristanmorgan tristanmorgan merged commit 0593d8b into main May 21, 2021
@tristanmorgan tristanmorgan deleted the complete-rewrite branch May 21, 2021 00:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants