Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Complete flags for -v command #81

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Complete flags for -v command #81

merged 1 commit into from
Jul 8, 2021

Conversation

tristanmorgan
Copy link
Owner

@tristanmorgan tristanmorgan commented Jul 5, 2021

Description

Fixes the ability for autocomplete to work for for aliased commands that have hyphens '-'.

Includes a few formatting changes.

Did you run the Tests?

  • Rubocop
  • Rspec
  • Filemode
  • Yard

self.class.map[sub_cmd].to_s
self.class.map[comp_lines[1]].to_s
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one line fix.

@tristanmorgan tristanmorgan requested a review from shamk23 July 7, 2021 02:58
expect { described_class.start(%w[__version]) }
expect { described_class.start(%w[--version]) }
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit test for "--version" command.

@tristanmorgan tristanmorgan merged commit 3e8cba8 into main Jul 8, 2021
@tristanmorgan tristanmorgan deleted the version-complete branch July 8, 2021 22:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants