-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Multiple bugs related to comment grammar #25
Comments
Thanks! Which version of the extension do you have installed, and do you have any other extensions that would affect rst files? |
v1.5.1 other reST extensions:
|
Thanks, I was able to reproduce this, and made a fix in #26, but this introduces a new issue where all blank lines in comments terminate the comment block, which isn't correct. I'll work on it some more, but if you want to test it, you can find the .vsix as a build artifact in that PR |
Sorry for the crazy long delay on this. I was able to resolve the issues I were seeing, and with the help of the test framework contributed in #34, I've added a couple of test cases that covers this scenario. I have merged the fix, and will make a new release on the marketplace. |
Example 1:
Expected: elements are recognized as a list and text block.
Actual: the entire paragraphs that starts with
...
is treated as a comment, which is just wrong.Example 2:
Actual: indented text is highlighted as a comment, which is incorrect.
..
is used intentionally here to end the list, otherwise intended text would be treated as a subelement of the list item B. Such use of..
is even presented in reST examples.Edit: I will try to post more examples if I encounter something reproducible, but so far I can say everything I have seen gone wrong was related to parsing of
..
.The text was updated successfully, but these errors were encountered: