Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: Allow top level headings without a child #36

Merged
merged 1 commit into from
Apr 15, 2023
Merged

fix: Allow top level headings without a child #36

merged 1 commit into from
Apr 15, 2023

Conversation

sgryjp
Copy link
Contributor

@sgryjp sgryjp commented Mar 19, 2023

Opening a document like below with v1.5.2 causes a problem reported in the issue #32:

Foo
===

Bar
===

This PR should fix the problem.

trond-snekvik
trond-snekvik approved these changes Apr 15, 2023
View reviewed changes
Copy link
Owner

@trond-snekvik trond-snekvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I haven't had the time to maintain this project for a long time. The fix looks good to me. I'll push a new release to the marketplace with the fix.

@trond-snekvik trond-snekvik merged commit 2ddf703 into trond-snekvik:main Apr 15, 2023
@trond-snekvik trond-snekvik mentioned this pull request Apr 15, 2023
Closed
@sgryjp sgryjp deleted the fix/first-heading-with-no-child branch April 16, 2023 12:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@trond-snekvik trond-snekvik trond-snekvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgryjp @trond-snekvik