Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding Datadog secrets checks for all regions #2265

Closed
carlesjavierre opened this issue Dec 29, 2023 · 2 comments · Fixed by #2510
Closed

Adding Datadog secrets checks for all regions #2265

carlesjavierre opened this issue Dec 29, 2023 · 2 comments · Fixed by #2510
Labels
contributions welcomed Signal for help from the community! enhancement help wanted

Comments

@carlesjavierre
Copy link

Please review the Community Note before submitting

Description

Being able to check for valid datadog keys on all regions

Preferred Solution

Sending an API check on every region or configure a specific region check to validate if it's a false positive or not. Right now it only checks the US1.

Additional Context

Checking only in the US1 region can lead to false true positives. Keys can be valid and just marked as false positives and nobody bothers to check them, since they're unverified (maybe old keys).

References

https://github.com/trufflesecurity/trufflehog/blob/main/pkg/detectors/datadogtoken/datadogtoken.go

US1 region: https://api.datadoghq.com
US3 region: https://api.us3.datadoghq.com
US5 region: https://api.us5.datadoghq.com
EU region: https://api.datadoghq.eu
AP1 region: https://api.ap1.datadoghq.com
US1-FED region: https://api.ddog-gov.com

@zricethezav zricethezav added help wanted contributions welcomed Signal for help from the community! labels Feb 6, 2024
@zricethezav
Copy link
Collaborator

Seems like a legit concern. We'll happily accept PRs for this issue

@simonwhitaker
Copy link
Contributor

simonwhitaker commented Feb 28, 2024

Seems like a legit concern. We'll happily accept PRs for this issue

@zricethezav You can find a proposed fix here: #2510

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
contributions welcomed Signal for help from the community! enhancement help wanted
Development

Successfully merging a pull request may close this issue.

3 participants