Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[refactor] - s3 metrics #3760

Merged
merged 2 commits into from
Dec 11, 2024
Merged

[refactor] - s3 metrics #3760

merged 2 commits into from
Dec 11, 2024

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Dec 10, 2024

Description:

This PR replaces counter-based Prometheus gauges with histograms.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav requested review from a team December 10, 2024 20:25
@ahrav ahrav marked this pull request as ready for review December 10, 2024 20:35
@ahrav ahrav requested review from a team as code owners December 10, 2024 20:35
rosecodym
rosecodym approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, neat! thanks for this!

@ahrav ahrav merged commit 3525c6f into main Dec 11, 2024
13 checks passed
@ahrav ahrav deleted the refactor-s3-metrics branch December 11, 2024 17:23
@blsaccess blsaccess mentioned this pull request Dec 12, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rosecodym rosecodym rosecodym approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrav @rosecodym