Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Jenkins happy-path logging #3908

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Add Jenkins happy-path logging #3908

merged 4 commits into from
Feb 12, 2025

Conversation

rosecodym
Copy link
Collaborator

@rosecodym rosecodym commented Feb 12, 2025 •
edited
Loading

Description:

This source doesn't log very much, so if it doesn't scan what you expect, it's hard to figure out why. This PR adds some logging.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rosecodym rosecodym requested review from a team as code owners February 12, 2025 18:35
casey-tran
casey-tran approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@casey-tran casey-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The increased logging looks good!

@rosecodym rosecodym merged commit 67bb639 into main Feb 12, 2025
13 checks passed
@rosecodym rosecodym deleted the jenkins-logging branch February 12, 2025 20:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@casey-tran casey-tran casey-tran approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosecodym @casey-tran