This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: queue calls to miner to allow multiple calls to evm_mine without awaiting
#3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
commented
Jun 16, 2022
| const block = await provider.request({ | ||
| method: "eth_getBlockByNumber", | ||
| params: [`0x1`] | ||
| const providerOptions: EthereumProviderOptions[] = [ |
There was a problem hiding this comment.
I've added only one new test to this file. Here, I'm running all of the pre-existing tests with both the "eager" and "strict" mode
MicaiahReid
commented
Jun 16, 2022
| ); | ||
| const provider = await getProvider({ | ||
| chain: { time: startDate }, | ||
| ...option |
There was a problem hiding this comment.
In some cases I have to merge our "instamine" options with other options needed for the test.
MicaiahReid
commented
Jun 16, 2022
| assert.strictEqual(currentBlock, initialBlock + 5); | ||
| }); | ||
|
|
||
| it("should mine `n` blocks if called `n` times without awaiting", async () => { |
There was a problem hiding this comment.
This is the only new test
MicaiahReid
changed the title
evm_mine hangingevm_mine without awaiting
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3248