Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

ci: drop ubuntu-18.04, add ubuntu-22.04 #3405

Merged
merged 2 commits into from
Jan 5, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@ jobs:
fail-fast: false
matrix:
node: [14.0.0, 14.x, 16.x, 18.x]
os: [windows-2019, ubuntu-18.04, ubuntu-20.04, macos-12]
exclude:
# Node v18 does not run on ubuntu-18.04: https://github.com/nodejs/node/issues/42351#issuecomment-1068424442
davidmurdoch marked this conversation as resolved.
Show resolved Hide resolved
- os: ubuntu-18.04
node: 18.x
os: [windows-2019, ubuntu-20.04, ubuntu-22.04, macos-12]

runs-on: ${{ matrix.os }}

Expand Down Expand Up @@ -47,7 +43,7 @@ jobs:

- name: Check bundle size
# this should match the os and version used in the release.yml
if: startsWith(matrix.os, 'ubuntu-20.04') && startsWith(matrix.node, '14.')
if: startsWith(matrix.os, 'ubuntu-22.04') && startsWith(matrix.node, '14.')
# 1. build ganache
# 2. pack it into a tarball
# 3. measure the _unpacked_ tarball's size
Expand All @@ -69,7 +65,7 @@ jobs:
INFURA_KEY: "badc0de0deadc0debadc0de0deadc0de"
- name: Upload artifact
# this should match the os and version used in the release.yml
if: startsWith(matrix.os, 'ubuntu-20.04') && startsWith(matrix.node, '14.')
if: startsWith(matrix.os, 'ubuntu-22.04') && startsWith(matrix.node, '14.')
uses: actions/upload-artifact@v3
with:
name: Candidate
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
fail-fast: false
matrix:
node: [14.0.0, 14.x, 16.x, 18.x]
os: [ubuntu-20.04]
os: [ubuntu-22.04]

runs-on: ${{ matrix.os }}

Expand All @@ -35,11 +35,7 @@ jobs:
fail-fast: false
matrix:
node: [14.0.0, 14.x, 16.x, 18.x]
os: [windows-2019, ubuntu-18.04, ubuntu-20.04, macos-12]
exclude:
# Node v18 does not run on ubuntu-18.04: https://github.com/nodejs/node/issues/42351#issuecomment-1068424442
- os: ubuntu-18.04
node: 18.x
os: [windows-2019, ubuntu-20.04, ubuntu-22.04, macos-12]

runs-on: ${{ matrix.os }}

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
release:
# this should match the os version used by the "check bundle size" step in
# pr.yml
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
outputs:
TAG: ${{ steps.set_tag_output.outputs.TAG }}
VERSION: ${{ steps.set_version_output.outputs.VERSION }}
Expand Down Expand Up @@ -169,7 +169,7 @@ jobs:

publish-docker:
needs: release
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
# because the docker publish action is an action we made, we have to
# check out the repo
Expand Down