This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: remove setting of private property #4145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
approved these changes
Jan 11, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the latest upgrade of etheremjs-vm, we would manually set the
_isInitializedproperty of theVMto avoid some extra computation that came along with initialization that we didn't need. After the ethereumjs-vm upgrde, creating theVMalso initializes it, so this manual setting of the private property is unnecessary, but we didn't remove it. This change removes the manual setting ofvm._isInitialized.