Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

chore:update direct dependencies #445

Merged
merged 5 commits into from
Jul 15, 2019
Merged

Conversation

davidmurdoch
Copy link
Member

Updates:

  • async to v2.6.2
  • debug to 3.2.6
  • eth-sig-util to 2.2.0
  • ethereumjs-abi to 0.6.7
  • ethereumjs-account to 3.0.0
  • ethereumjs-block to 2.2.0
  • ethereumjs-util to 6.1.0
  • ethereumjs-vm to 3.0.0
  • lodash to 4.17.14
  • merkle-patricia-tree to 2.3.2
  • seedrandom to 3.0.1
  • source-map-support to 0.5.12
  • tmp to 0.1.0
  • web3-provider-engine to 14.2.0
  • websocket to 1.0.29
  • coveralls to ^3.0.4
  • eslint-plugin-promise to 4.2.1
  • prettier to ^1.18.2

Copy link
Contributor

@nicholasjpaterno nicholasjpaterno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, everything LGTM! Let's discuss the tx signatures a bit when you're back in the office!

// of `0` or `1` like it used to.
// Additionally, the output of 27/28 vs 0/1 is uncertain and hasn't yet been
// decided upon (geth apparently using both?).
// See: https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1622
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an update on this. ethereum/go-ethereum#19751 (comment)

@davidmurdoch davidmurdoch merged commit d4e0018 into develop Jul 15, 2019
@davidmurdoch davidmurdoch deleted the chore/update-dependencies branch September 20, 2019 23:25
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants