truffle publish chokes on the gathering contracts... step for some repos

[skmgoldin]

Issue

truffle publish chokes on the gathering contracts... step for some repos. It seems like it's failing to parse contracts that it doesn't have any issues with when you truffle compile.

Steps to Reproduce

git clone git@github.com:ConsenSys/PLCRVoting.git
cd PLCRVoting
git checkout ecc6bf0799b9c0bb71a21e25aeaeaae5d79ba6b5
npm i
npm run compile
npm run publish

Expected Behavior

I expect the publication to succeed. (The particular thing you're checking out to reproduce should eventually fail because there's no secrets.json file, but the compilation step should not be failing, and it behaves the same if you do give it a funded secrets.json).

Actual Results

Compilation fails. But compilation succeeds if you do truffle compile!

Environment

• Operating System: Ubuntu 16
• Truffle version: 4.0.4
• Ethereum client: INFURA
• node version: 8
• npm version: 5

[gitcoinbot]

This issue now has a funding of 0.2 ETH (150.09 USD @ $750.43/ETH) attached to it.

• If you would like to work on this issue you can claim it here.
• If you've completed this issue and want to claim the bounty you can do so here
• Questions? Get help on the Gitcoin Slack
• $6649.22 more Funded OSS Work Available at: https://gitcoin.co/explorer

[gitcoinbot]

Work has been started on the 0.2 ETH (84.47 USD @ $422.33/ETH) funding by:

1. @vladfr

Please work together and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@skmgoldin) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

• Learn more on the gitcoin issue page
• Questions? Get help on the Gitcoin Slack
• $4011.48 more Funded OSS Work Available at: https://gitcoin.co/explorer

[vladfr]

@skmgoldin - hi, I was able to reproduce this, I'll take a stab at fixing it this week.

[vladfr]

@skmgoldin Hey, so this happens in truffle-compile/parser.js. When it merges all files into one .sol and sends it to solc, it does not filter by warnings. Therefore, all errors + warnings are seen as Exceptions and stop the publish.

The compile command has its strict mode off, which means it's filtering out warnings.

A second issue is that the compiler can't resolve imports correctly, so if you actually use a function from an import, it will fail when doing parse like truffle publish does.

Submitted trufflesuite/truffle-compile#48

[gitcoinbot]

Work for 0.2 ETH (131.56 USD @ $657.81/ETH) has been submitted by:

1. @vladfr

Submitters, please leave a comment to let the funder (@skmgoldin) (and the other parties involved) that you've submitted you work. If you don't leave a comment, the funder may expire your submission at their discretion.

• Learn more on the gitcoin issue page
• Questions? Get help on the Gitcoin Slack
• $5453.56 more Funded OSS Work Available at: https://gitcoin.co/explorer

[skmgoldin]

Thanks @vladfr ! If you can get it merged, I will release the kraken bounty!

[vs77bb]

Hi @skmgoldin @vladfr is this one still WIP? I see it's in a Work Submitted status on Gitcoin, but perhaps is still pending merge? Hope you both are doing well 🙂

[cgewecke]

@vs77bb Yes it's still claimed and not open. @vladfr has done nice work on this, we're currently reviewing.

[gnidan]

@skmgoldin: @vladfr's PR is merged; will go out with the next release. Thanks!

[vladfr]

Thanks!

…

On Thu, Mar 22, 2018, 19:10 gnidan ***@***.***> wrote: @skmgoldin <https://github.com/skmgoldin>: @vladfr <https://github.com/vladfr>'s PR is merged; will go out with the next release. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#744 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAM-h5qu17FOSACEg7UXnveOfCOjaTf2ks5tg9segaJpZM4RYnl1> .

[gnidan]

@skmgoldin This has been released in v4.1.4. Mind verifying the fix?

[skmgoldin]

Oooooooooh shit so exciting!!!! Will report back!

[skmgoldin]

It worked! https://www.ethpm.com/registry/packages/43 @vladfr I will pay you.

[gitcoinbot]

The funding of 0.2 ETH (77.04 USD @ $385.18/ETH) attached to this issue has been approved & issued to @vladfr.

• Learn more at on the gitcoin issue page
• Questions? Get help on the Gitcoin Slack
• $2561.07 more Funded OSS Work Available at: https://gitcoin.co/explorer

[cgewecke]

Closing, thanks all!