Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update default SVGO configuration file to an ESM Module #192

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

andreilgeorgescu
Copy link
Contributor

Updating the default SVGO configuration to an ES Module helps future-proof it and prevent issues with NPM projects set to "type": "module".

@TylerJang27
Copy link
Collaborator

Thanks for the PR! The default generated config file is actually in https://github.com/trunk-io/plugins/blob/main/linters/svgo/svgo.config.js. I will verify and duplicate this change over

Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm adding the relevant change in trunk-io/plugins#952 as well

@TylerJang27 TylerJang27 merged commit e6d455f into trunk-io:main Jan 7, 2025
3 checks passed
TylerJang27 added a commit to trunk-io/plugins that referenced this pull request Jan 7, 2025
@andreilgeorgescu andreilgeorgescu deleted the patch-1 branch January 8, 2025 17:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants