Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix terrascan #534

Closed
wants to merge 2 commits into from
Closed

Fix terrascan #534

wants to merge 2 commits into from

Conversation

TylerJang27
Copy link
Collaborator

Terrascan is failing tests on MacOS nightly and Windows but not on Linux. They haven't released an update in a while, so this is likely a slight regression due to our PATH changes. Nevertheless, this is the only linter that's having a problem, and since terrascan appears to need to be git aware, we simply will add the SYSTEM path here.

@trunk-io
Copy link

trunk-io bot commented Oct 23, 2023

⏱️ 1h 15m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests (macos-latest) 50m 🟥🟥
Windows Linter Tests 11m 🟥🟥🟥
Linter Tests (ubuntu-latest) 5m 🟩🟩
CodeQL-Build 4m 🟩🟩
Trunk Check runner [linux] 2m 🟩🟩
Repo Tests / Plugin Tests 2m 🟩🟩
Trunk Check 1m 🟩🟩
Aggregate Test Results 13s 🟥🟥🟥
Detect changed files 12s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 marked this pull request as ready for review October 23, 2023 18:52
@TylerJang27 TylerJang27 requested review from det and laurit17 October 23, 2023 18:52
@TylerJang27
Copy link
Collaborator Author

Missed the mark on this. Even adding a prepare_run for terrascan init does not fix it (or using a tools install). Seems to be their issue, +1'd the bug report.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants