Add asset processing for script tags
#332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctron
changed the title
script tagsscript tags
ctron
force-pushed
the
feature/js_asset_1
branch
from
b79c8de to
b5579de
Compare
thedodd
requested changes
Jun 30, 2022
There was a problem hiding this comment.
This is looking pretty awesome, thanks for this work! I would ask that you integrate this feature into one of the current examples as a way to be able to test this feature.
As unit/integration testing is not nearly where it needs to be in this system, this is one of the primary ways to ensure features continue to work as needed (as well as first-line verification).
ctron
force-pushed
the
feature/js_asset_1
branch
from
b5579de to
92628c5
Compare
|
I rebased the PR. And added its use to the |
thedodd
requested changes
Jul 2, 2022
|
Glad you like it! I amended the PR with your recommended changes. I agree, the name is more appropriate now. I just didn't want to change that many file upfront :) |
Co-authored-by: Anthony Dodd <dodd.anthonyjosiah@gmail.com>
thedodd
approved these changes
Jul 5, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
sitecontent with pertinent info (may not always apply).This change adds support for processing
<script>tags with the asset pipeline in a way similar to<link rel="css">assets. This fixes the request originally posted by @hobofan in #3 (comment)