Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bump littlefs2-sys for littlefs 2.6 #42

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bump littlefs2-sys for littlefs 2.6 #42

wants to merge 3 commits into from

Conversation

sosthene-nitrokey
Copy link
Contributor

This fixes a bug encountered in #33

According to the littlefs release notes, this shouldn't be a breaking change, but we should still test it nonetheless.

@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Jun 9, 2023
Open
@sosthene-nitrokey sosthene-nitrokey requested review from robin-nitrokey and nickray and removed request for robin-nitrokey June 12, 2023 09:26
@elpiel
Copy link
Contributor

elpiel commented Jun 26, 2023

I managed to compile and try to mount an SD card storage implementation with embedded-sdmmc.
Sadly on mount it gives me an error "Invalid".
I will try with a brand new filesystem just in case and try to format the card using littlefs-fuse once again.

Is there anything more specific to the migration process?
Do I need to update littlefs-fuse's version of littlefs?

@elpiel
Copy link
Contributor

elpiel commented Jun 27, 2023

I manged to format and write to the SD card.
One of the issues that might have caused problems was littlefs-fuse. It also has releases for each littlefs version but releases haven't been updated properly.

Now with the master branch up to date I can also test the littlefs-fuse mounting and see if any problem arises from that.

@sosthene-nitrokey
Add filesystem persistence test
5e51915 
This adds tests for generating filesystems with a version.
It also adds tests that those filesystems are read properly.

This will help avoid breaking backward compatibility
@sosthene-nitrokey
Bump littlefs2-sys
800bccf
@sosthene-nitrokey
Make metadata_max configurable through the Storage trait
f718fc2
@sosthene-nitrokey
Copy link
Contributor Author

I did some testing once and it lead to the filesystem also failing to load though I didn't perform a thorough investigation as I was investigating another issue which I hoped would be solved by a more recent littlefs version, which wasn't the case.

I've added a couple test that generate a filesystem with the old version and reads them with the new and it seems to work fine.

@elpiel
Copy link
Contributor

elpiel commented Jul 1, 2023

I've tested the new version by formatting the SD card using littlefs-fuse and then running some code on the device.
I still get an Invalid error.

I've been experiencing another issue when I format the SD card on the device. littlefs-fuse gives me error for incorrect block size but let me open an issue once I collect the details in coherent way.

@elpiel
Copy link
Contributor

elpiel commented Jul 17, 2023

@sosthene-nitrokey any progress on upgrading littlefs?
There's a new release 2.7 from 2 weeks ago that adds some support for older littlefs protocol:

https://github.com/littlefs-project/littlefs/releases/tag/v2.7.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nickray nickray Awaiting requested review from nickray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosthene-nitrokey @elpiel