Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Reuse the MQ parameters for operation queue #1390

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

bstasyszyn
Copy link
Contributor

There is no need to have a separate set of parameters for the operation queue that dictate retry behavior since the parameters are already defined for the pub-sub subsystem.

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Jun 30, 2022
There is no need to have a separate set of parameters for the operation queue that dictate retry behavior since the parameters are already defined for the pub-sub subsystem.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@bstasyszyn bstasyszyn force-pushed the reuse_mq_params_for_opqueue branch from aca7682 to 29a0c48 Compare June 30, 2022 14:46
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1390 (29a0c48) into main (224d8bc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
- Coverage   88.04%   88.02%   -0.02%     
==========================================
  Files         205      205              
  Lines       19106    19094      -12     
==========================================
- Hits        16821    16807      -14     
- Misses       1467     1468       +1     
- Partials      818      819       +1     
Impacted Files Coverage Δ
pkg/context/opqueue/opqueue.go 82.28% <ø> (ø)
cmd/orb-server/startcmd/params.go 82.13% <100.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224d8bc...29a0c48. Read the comment docs.

@fqutishat fqutishat merged commit 6dbcaa0 into trustbloc:main Jun 30, 2022
@bstasyszyn bstasyszyn deleted the reuse_mq_params_for_opqueue branch June 30, 2022 16:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants