Fix logic/syntax bugs with switch statements matching multiple values #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a bit of tinkering, I figured out the cause of Issues trympet#18, trympet#22, and trympet#23. The OR (||) conditional for multiple case values was not working as intended -- they only matched the first value in each case instead of any of the values separated by ||. Converting those to use the fall-through feature of the switch statement resolved the problems.
|
Good observation. Thanks for the PR! |
This was
linked to
issues
Sep 12, 2021
Closed
Closed
This was referenced Sep 12, 2021
Closed
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bit of tinkering, I figured out the cause of Issues #18, #22, and #23. The OR (||)
conditional for multiple case values was not working as intended -- they only matched the first
value in each case instead of any of the values separated by ||.
Converting those to use the fall-through feature of the switch statement resolved the problems.