Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use an alternative to q-io/fs #152

Closed
dignifiedquire opened this issue Dec 9, 2016 · 2 comments
Closed

Use an alternative to q-io/fs #152

dignifiedquire opened this issue Dec 9, 2016 · 2 comments

Comments

@dignifiedquire
Copy link

I've been using this module with great enjoyment, but sadly it breaks other code by simply requiring it. You can find the details here: ipfs/aegir#79 (comment). The gist is, that q-io uses a module collections which modifies global prototypes.

This could be easily fixed here, by using something another promise wrapper around fs than q-io. I've also opened an issue on q-io to fix this, but wanted to mention this here as well. kriskowal/q-io#160
@sid-maddy
Copy link

There's already an issue #42 and an abandoned PR #44

@dignifiedquire
Copy link
Author

Sorry about that, didn't see it. Closing as duplicate

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dignifiedquire @sid-maddy