Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#42 removed q-io and use mkdirp instead for creating folder. #44

Closed
wants to merge 1 commit into from
Closed

Conversation

morlay
Copy link

@morlay morlay commented Jan 10, 2016

No description provided.

@markdalgleish
Copy link
Collaborator

This is a larger and riskier change than I had anticipated. Should this not instead be an issue raised against q-io?

Is this causing any real-world issues at the moment? I understand the theoretical risk here, but given gh-pages is a small tool that doesn't run in an application context, it seems very low risk to me right now.

@morlay
Copy link
Author

morlay commented Jan 11, 2016

But someone may use this in the build system like gulp or others.
When we config gh-pages in the build system, it will be loaded with the collections to overwrite the Array methods, even not running.

For the risk. I tested in node 4 & 5.
https://github.com/morlay/gh-pages/tree/gh-pages

@Klortho
Copy link

Klortho commented Feb 16, 2016

FWIW, this looks like an improvement to me. +1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants