fixed check

tschaub · Apr 21, 2020 · 56801da · 56801da
1 parent 59eef81
commit 56801da
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/lib/binding.js b/lib/binding.js
@@ -962,8 +962,9 @@ Binding.prototype.readdir = function(
     if (!(dir instanceof Directory)) {
       throw new FSError('ENOTDIR', dirpath);
     }
-
-    this.access(dirpath, parseInt('0002', 8));
+    if (!dir.canRead()) {
+      throw new FSError('EACCES', dirpath);
+    }
 
     let list = dir.list();
     if (encoding === 'buffer') {

diff --git a/test/lib/fs.readdir.spec.js b/test/lib/fs.readdir.spec.js
@@ -253,10 +253,4 @@ describe('fs.readdirSync(path)', function() {
       fs.readdirSync('denied');
     });
   });
-
-  it('throws when access refused', function() {
-    assert.throws(function() {
-      fs.readdirSync('denied');
-    });
-  });
 });