fs.rmdir looks not support "recursive"

[kunyan]

fs.rmdir("/some/path", {recursive: true })

Will get error

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received an instance of Buffer

[3cp]

You are right, recursive is only implemented for mkdir now. I will try to implement it when I got time. But you are welcome to contribute :-)

[kunyan]

I'm trying to implement this feature in my local, however. the arguments in Binding.prototype.rmdir always not have new arg when I run ./test/lib/fs.rmdir.spec.js

And I also found where the error message coming from

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received an instance of Buffer

The arguments[0], path will be convert to a Buffer in readdir

mock-fs/lib/index.js

Line 35 in 9832d66

return this._mockedBinding[key].apply(this, arguments);

I think there has some difference in Node v12 ?

[3cp]

From nodejs source code

function lazyLoadRimraf() {
  if (rimraf === undefined)
    ({ rimraf, rimrafSync } = require('internal/fs/rimraf'));
}

function rmdir(path, options, callback) {
  if (typeof options === 'function') {
    callback = options;
    options = undefined;
  }

  callback = makeCallback(callback);
  path = pathModule.toNamespacedPath(getValidatedPath(path));
  options = validateRmdirOptions(options);

  if (options.recursive) {
    lazyLoadRimraf();
    return rimraf(path, options, callback);
  }

  const req = new FSReqCallback();
  req.oncomplete = callback;
  binding.rmdir(path, req);
}

The binding.rmdir (where you expect the new option) does not handle this new option, but a newly created rimraf (from 'internal/fs/rimraf') does some wrap around other fs and binding calls to implement the recursive deleting.

I will try to glue them up.

[3cp]

Because nodejs v12 implemented recursive rmdir though 'internal/fs/rimraf', there is nothing we need here.

The broken support was due to a bug of mock-fs: not supporting Buffer typed path input. More details in #293.

[kunyan]

Please bump a new version for changes. thanks a lot

[tschaub]

Fix published in mock-fs@4.12.0.