-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bypass updates #306
Bypass updates #306
Conversation
Instead of playing _mockedBinding, it's probably cheaper and less code if we use a boolean flag on realBinding to temporarily disable mocking. |
It looks like there will be more to do to get |
The patches for cwd/chdir/createWriteStream/binding should all check the same _mockedBinding (or a flag) on realBinding. This also means we only need to patch them once without real restore. The restore (not just for bypass) only needs to remove _mockedBinding (and the flag). I will create a draft. |
Could you merge #303 first? |
All the patches now check same realBinding._mockedBinding. This should fix the edge cases around the new feature bypass(). follows up #306
All the patches now check same realBinding._mockedBinding. This should fix the edge cases around the new feature bypass(). follows up #306
All the patches now check same realBinding._mockedBinding. This should fix the edge cases around the new feature bypass(). follows up #306
This is a follow-up to #304.