Add Node 20 #171
Merged
Add Node 20 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orta
reviewed
Apr 17, 2023
| "compilerOptions": { | ||
| "lib": ["es2023"], | ||
| "module": "commonjs", | ||
| "target": "es2022", |
There was a problem hiding this comment.
I think we probably want to bump target here also
There was a problem hiding this comment.
ES2022 is the latest target
$ tsc --version
Version 5.0.4
$ tsc --target ES2023
error TS6046: Argument for '--target' option must be: 'es3', 'es5', 'es6', 'es2015', 'es2016', 'es2017', 'es2018', 'es2019', 'es2020', 'es2021', 'es2022', 'esnext'.
|
Looks good to me aside for the target, nice work |
|
Should deploy overnight! |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 20 is set to be released tomorrow1 (2023-04-18). The configuration should be identical to Node 18, as far as I can tell.
Footnotes
https://github.com/nodejs/Release#release-schedule ↩