Skip to content

Fix node traversal orderings to work with virtual_root #1725

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jeromekelleher opened this issue Sep 18, 2021 · 0 comments
Closed

Fix node traversal orderings to work with virtual_root #1725

jeromekelleher opened this issue Sep 18, 2021 · 0 comments
Assignees
@jeromekelleher
Labels
bug Something isn't working Python API Issue is about the Python API
Milestone
Python 0.4.0

Comments

@jeromekelleher
Copy link
Member

Currently the orders

               # "postorder",
                # "timeasc",
                # "timedesc",
                # "minlex_postorder",

don't work properly if we supply virtual_root as the root argument to the Tree.nodes method.
@jeromekelleher jeromekelleher added the Python API Issue is about the Python API label Sep 18, 2021
@jeromekelleher jeromekelleher added this to the Python 0.3.8 milestone Sep 18, 2021
@jeromekelleher jeromekelleher self-assigned this Sep 18, 2021
@jeromekelleher jeromekelleher added the bug Something isn't working label Sep 18, 2021
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 11, 2021
@jeromekelleher
Update node traversals and virual root semantics
b70e8a1 
Change timeasc and timedesc to keep the tree ordering within a
timeslice rather than sorting by node ID (potentially breaking)
Closes tskit-dev#1776

Closes tskit-dev#1725
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 11, 2021
@jeromekelleher
Update node traversals and virual root semantics
e483f80 
Change timeasc and timedesc to keep the tree ordering within a
timeslice rather than sorting by node ID (potentially breaking)
Closes tskit-dev#1776

Closes tskit-dev#1725
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 11, 2021
@jeromekelleher
Update node traversals and virual root semantics
fa24a27 
Change timeasc and timedesc to keep the tree ordering within a
timeslice rather than sorting by node ID (potentially breaking)
Closes tskit-dev#1776

Closes tskit-dev#1725
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 11, 2021
@jeromekelleher
Update node traversals and virual root semantics
5055ac2 
Change timeasc and timedesc to keep the tree ordering within a
timeslice rather than sorting by node ID (potentially breaking)
Closes tskit-dev#1776

Closes tskit-dev#1725
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 12, 2021
@jeromekelleher
Update node traversals and virual root semantics
218fd6f 
Change timeasc and timedesc to keep the tree ordering within a
timeslice rather than sorting by node ID (potentially breaking)
Closes tskit-dev#1776

Closes tskit-dev#1725
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 13, 2021
@jeromekelleher
Update node traversals and virual root semantics
fcc5ea0 
Change timeasc and timedesc to keep the tree ordering within a
timeslice rather than sorting by node ID (potentially breaking)
Closes tskit-dev#1776

Closes tskit-dev#1725
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 13, 2021
@jeromekelleher
Tidy up some details
14042d1 
Closes tskit-dev#1725
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 13, 2021
@jeromekelleher
Update node traversals and virual root semantics
5fb52f8 
Change timeasc and timedesc to keep the tree ordering within a
timeslice rather than sorting by node ID (potentially breaking)
Closes tskit-dev#1776

Closes tskit-dev#1725
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 13, 2021
@jeromekelleher
Tidy up some details
12e1ae5 
Closes tskit-dev#1725
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 14, 2021
@jeromekelleher
Refactor node traversal tests
e2fce13 
Change timeasc and timedesc to keep the tree ordering within a
timeslice rather than sorting by node ID (potentially breaking)
Closes tskit-dev#1776

Closes tskit-dev#1725
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 14, 2021
@jeromekelleher
Add tsk_tree_size_bound to enable safe allocations
f7988b0 
Closes tskit-dev#1725
jeromekelleher added a commit to jeromekelleher/tskit that referenced this issue Oct 18, 2021
@jeromekelleher
Add tsk_tree_size_bound to enable safe allocations
edbaaca 
Closes tskit-dev#1725
@mergify mergify bot closed this as completed in a0af17b Oct 18, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jeromekelleher jeromekelleher

Labels
bug Something isn't working Python API Issue is about the Python API
Projects
None yet
Milestone
Python 0.4.0
Development

No branches or pull requests
1 participant
@jeromekelleher