Use virtual root #1799
Merged
Use virtual root #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
- Coverage 93.40% 93.38% -0.03%
==========================================
Files 27 27
Lines 24773 24783 +10
Branches 1095 1094 -1
==========================================
+ Hits 23140 23144 +4
- Misses 1598 1604 +6
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jeromekelleher
force-pushed
the
use-virtual-root
branch
2 times, most recently
from
f5718de to
a0498a9
Compare
|
Some useful applications of virtual root here and the new ordering functions. Ready for review, but needs #1704 merged first. |
jeromekelleher
force-pushed
the
use-virtual-root
branch
from
a0498a9 to
b85245a
Compare
|
@Mergifyio rebase |
Closes tskit-dev#1787 Note we have left out updating the traversals in vargen for now because it is undergoing a large refactoring anyway.
Closes tskit-dev#1794 Benchmarks: Before: big_tree 0.26075993799986463 many_trees 0.002319710470019345 After: big_tree 0.004731306999929075 many_trees 2.1276080024108523e-05 So 2-3 orders of magnitude (probably more compared to previous release, since this using faster node iteration)
jeromekelleher
force-pushed
the
use-virtual-root
branch
from
b85245a to
02d4771
Compare
✅ Branch has been successfully rebased |
|
Bumping this @benjeffery - good to get it in to unblock other stuff |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #1704