Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't omit lpNumberOfBytesWritten parameter passed to WriteFile() #14

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

ChronoMonochrome
Copy link
Contributor

On Windows 7, this parameter cannot be NULL.
Passing a non-null parameter fixes the program crash.

Reference: https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-writefile

On Windows 7, this parameter cannot be NULL.
Passing a non-null parameter fixes the program crash.

Reference: https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-writefile
@rexim
Copy link
Member

rexim commented Sep 5, 2023

@ChronoMonochrome interesting! Didn't know that! Thank you for fixing this! 👍

@rexim rexim merged commit afb6100 into tsoding:master Sep 5, 2023
@ChronoMonochrome
Copy link
Contributor Author

You're welcome!

Yeah I didn't know about this detail on how WriteFile works too. Great project btw, looking forward for the further development!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants