-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feat: build hashing #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96330ed
to
f315352
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build Hashing
Reason for changes
We should probably allow hashing js and css in production.
Key Changes
Approach
It looks like the browser treats our css and js as technically "external" css/js under srcipt-src-elem or style-src-elem which means if we are hashing this requires integrity hashes as documented here
For scripts looks like we need to add integrity & hashes
For styles looks like we need to add integrity & hashes also but we also need to add "self" in the policy.
How does setting integrity to javascript/css thats lazy loaded in work? -> This needs the 'self' in the policy also
Leads me to believe hashing these is pretty pointless honestly
Conclusion
Okay so for build - we actually need 'self' directives on both JS and CSS imports.
Self should be a default in both.
We should probably not be hashing these - OR we should optionally hash them with the integrity attribute added. But in both of these scenario's we should still include the
'self'
directive, because its required to make the majority of SPA's work!Other conclusion is we should probably change the name of this package, to
vite-plugin-csp-guard
??Checklist