Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

#54 Keep parameters in their relative lines when in multi-line configuration. #61

Merged
merged 2 commits into from
Dec 20, 2024
Merged

#54 Keep parameters in their relative lines when in multi-line configuration. #61

merged 2 commits into from
Dec 20, 2024

Conversation

mofantor
Copy link
Contributor

  1. Migrate all directive parameters to the Parameter object
  2. The Parameter object stores the relative line index to the directive, allowing the dump to retain the original layout
  3. During parsing, obtain and store the relative line index of parameters to the directive
  4. During dump, restore the original relative line index

@mofantor
1. Migrate all directive parameters to the Parameter object
e25cfaa 
2. The Parameter object stores the relative line index to the directive, allowing the dump to retain the original layout
3. During parsing, obtain and store the relative line index of parameters to the directive
4. During dump, restore the original relative line index
@mofantor mofantor mentioned this pull request Dec 15, 2024
Closed
@tufanbarisyildirim
Copy link
Owner

oh! wow, that's great @mofantor can you please have a look at linter warnings? let's make it happy and we ship this!

@tufanbarisyildirim tufanbarisyildirim merged commit a841740 into tufanbarisyildirim:master Dec 20, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mofantor @tufanbarisyildirim