Skip to content

fix: Align the sorting of project references with Xcode 16 #937

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

mikhailmulyar
Copy link
Contributor

Short description 📝

If project saved with XcodeProj then opening it with Xcode 16 generate some changes. So we could respect Xcode 16 sorting by sorting our result with the same way.

Solution 📦

Do the same sorting as Xcode 16 do


NB! This PR is copy of #867 with proper tests added.

@pepicrft pepicrft changed the title Sort project references as Xcode 16 does fix: Align the sorting of project references with Xcode 16 May 16, 2025
@pepicrft pepicrft self-requested a review May 16, 2025 13:25
@pepicrft
Copy link
Contributor

@mikhailmulyar you'll have to run mise run lint-fix to fix the linting issues. After that, we should be good to go once CI is green.

@pepicrft
Copy link
Contributor

@all-contributors add @mikhailmulyar for code

Copy link
Contributor

@pepicrft

I've put up a pull request to add @mikhailmulyar! 🎉

@mikhailmulyar
Copy link
Contributor Author

@mikhailmulyar you'll have to run mise run lint-fix to fix the linting issues. After that, we should be good to go once CI is green.

Added fix

@mikhailmulyar
Copy link
Contributor Author

mikhailmulyar commented May 20, 2025

@pepicrft Looks like code linter issues fixed. It has failed on PR title linting.

@pepicrft pepicrft merged commit 7077226 into tuist:main May 20, 2025
5 of 6 checks passed
@pepicrft
Copy link
Contributor

Thanks @mikhailmulyar. That one yields false positives sometimes, so we can ignore and merge. I'll into why we are getting those later.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants