New ckanext-grouphierarchy version and personalised license list #31
Conversation
|
Changes are tested locally with
|
| @@ -159,6 +166,7 @@ for production environments.** | |||
| ### Known issues | |||
|
|
|||
| [Unreleased]: https://github.com/tum-gis/ckan-docker/compare/1.1.2...HEAD | |||
There was a problem hiding this comment.
Increase version here too, to show commits between latest release and latest commit.
There was a problem hiding this comment.
Do you mean this :
https://github.com/tum-gis/ckan-docker/blob/devel-update/CHANGELOG.md?plain=1#L170 ?
It is already changed for v1.1.3
|
|
||
| ### Fixed | ||
|
|
||
| - upstream bugfix from [ckanext-grouphierarchy-sddi](https://github.com/tum-gis/ckanext-grouphierarchy-sddi) extension tum-gis/ckanext-grouphierarchy-sddi#17 |
There was a problem hiding this comment.
Please describe shortly, what was fixed. Just letting people know, that this is an upstream bugfix is not helpful.
sddi-base/Dockerfile
Outdated
| @@ -192,6 +192,7 @@ RUN set -ex && \ | |||
| ckan config-tool "${CKAN_INI}" "scheming.dataset_schemas = ckanext.scheming:ckan_dataset.yaml" && \ | |||
| ckan config-tool "${CKAN_INI}" "scheming.presets = ckanext.scheming:presets.json ckanext.repeating:presets.json ckanext.composite:presets.json" && \ | |||
| ckan config-tool "${CKAN_INI}" "scheming.dataset_fallback = false" && \ | |||
| ckan config-tool "${CKAN_INI}" "licenses_group_url = https://raw.githubusercontent.com/tum-gis/ckanext-grouphierarchy-sddi/main/ckanext/grouphierarchy/licenses_SDDI.json" &&\ | |||
There was a problem hiding this comment.
- Missing space after
&& - Is setting this here really required? If this file is the default, it should be shipped with the extension (which is the case, according to the URL) and set as the default value (local path inside the container) in the extension. The user should only have to take action, if he needs to overwrite this.
There was a problem hiding this comment.
This is an extended license list which is required for SDDI. With CKAN installation it comes default licenses list.
With the URL which is defined in mentioned Dockerfile, I want to overwrite CKAN Default value and use customized list.
This value could be defined as ENV var which I've added in our docker/compose installation draft.
No description provided.