Changes to CMakeLists and Package Files #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d compile under Indigo with OpenCV 3
| @@ -97,7 +99,7 @@ include_directories( | |||
|
|
|||
| # build shared library. | |||
| add_library(lsdslam SHARED ${SOURCE_FILES}) | |||
| target_link_libraries(lsdslam ${FABMAP_LIB} ${G2O_LIBRARIES} ${catkin_LIBRARIES} csparse cxsparse ) | |||
| target_link_libraries(lsdslam ${FABMAP_LIB} ${G2O_LIBRARIES} ${catkin_LIBRARIES} csparse cxsparse X11 ${OpenCV_LIBS}) | |||
There was a problem hiding this comment.
I don't understand how this can link correctly without these additions. Am I missing something?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a lot of trouble compiling on 14.04 with Indigo and OpenCV3. The changes in this pull request finally got it done. Some things are necessities for Indigo that were not there in older versions, others are just telling cmake to find and link necessary libraries (OpenCV and X11).