feat: init new git repo for new projects #558
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
I added a few comments to refine messages and comments.
Let me know what do you think 😉
(The code review will still be performed by @Valerioageno since I'm not a rust expert 😅)
Thank you! What do you think of my proposed logic for the git workflow (description in PR overview)? |
crates/tuono/tests/cli_build.rs
Outdated
There was a problem hiding this comment.
Anyway cargo test is failing again because the command output is:
Failed to parse the tag response
rather than exiting with a success status code.
This makes me wondering if there is a temporary issue with GitHub API since rerunning produced, again, no errors.
@Valerioageno I think this should be resolved by using a mock server when executing unit tests,
which is already worked on #411.
However the work is halted due to a missing release of .dotenvy crate.
Maybe there is another way to go ahead?
E.g. Creating a trait hardcoding the GitHub domain for production and mocking it with the local mock server during unit tests?
There was a problem hiding this comment.
Yeah, definitely needs to create the mock first.
Let's put these tests in a separate branch and merging them once the above PR gets merged.
Note: These tests should be put in tests/cli_new.rs
crates/tuono/tests/cli_build.rs
Outdated
There was a problem hiding this comment.
Yeah, definitely needs to create the mock first.
Let's put these tests in a separate branch and merging them once the above PR gets merged.
Note: These tests should be put in tests/cli_new.rs
crates/tuono/tests/cli_build.rs
Outdated
| #[test] | ||
| #[serial] | ||
| fn it_inits_new_git_repo_by_default_with_git_installed() { | ||
| let temp_tuono_project = TempTuonoProject::new(); |
There was a problem hiding this comment.
The same problem in the unit test happens here (if the host machine has not installed git the tests fail).
We should consider mocking it, otherwise we gonna increase test complexity and flakiness
|
Please can I have a bit of help here? When I use I could ignore the dead code warning, but that feels bad. WDYT? |
Checklist
Related issue
Fixes #554
Overview
Checks if git is installed, and init a new repo by default. If git is not installed, we continue in silence, and only fail with error if the user specifies the git flag, but git is not installed.
Tasks
Add flag to docs (not much to do, but will update the help snippet on the cli page)