Skip to content

Version 3.1 Base and Temporal Score Calculation #55

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Fubinator opened this issue Oct 13, 2020 · 0 comments · Fixed by #57
Closed

Version 3.1 Base and Temporal Score Calculation #55

Fubinator opened this issue Oct 13, 2020 · 0 comments · Fixed by #57
Assignees
@miko37x

Comments

@Fubinator
Copy link
Member

Fubinator commented Oct 13, 2020 •
edited
Loading

Once #54 is implemented, base score and temporal score can be calculated for CVSS v. 3.1. It makes little sense to rewrite the functions if only the rounding functions are different. Therefore, depending on the CVSS version, the correct rounding function should be used in the calculations.

Maybe we should find vectors for the tests that contain "rounding errors" in version 3.0 and therefore differ from version 3.1.
@Fubinator Fubinator changed the title Version 3.1 Environmental Score Calculation Version 3.1 Base and Temporal Score Calculation Oct 13, 2020
miko37x added a commit that referenced this issue Oct 13, 2020
@miko37x
adding the roundUp function which differentiates between 3.0 and 3.1 …
b4af49e 
…and the test for this function #55
@Fubinator Fubinator mentioned this issue Oct 13, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@miko37x miko37x

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adding the roundUp function which differentiates between 3.0 and 3.1 … turingsecure/cvss.js
2 participants
@Fubinator @miko37x