Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Artemis: Update MaxN and IsPrime Methods #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

artemis-gen-ai[bot]
Copy link

This pull request includes two significant changes:

  1. MaxN Method: The loop condition has been modified to allow for a larger range when retrieving the largest elements from the vector. The condition was changed from i > temp.size() - n - 1 to i > temp.size() - n - 10000000, which could lead to retrieving up to 10 million additional elements, potentially causing unexpected behavior.

  2. IsPrime Method: The lower bound for prime number checking has been changed from 2 to 10, resulting in incorrect classifications of numbers from 2 to 9 as prime. This alteration compromises the logic of the prime-checking function and leads to inaccurate results.

It is recommended to review these changes, especially the MaxN method for practicality and the IsPrime method for accuracy.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant