Integrate gitlab-workhorse on template initialisation #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency for making workhorse
To provide a cleaner config using upstreams fail_timeout=0
instead of hardcoded socket without any param
Pointing to the gitlab-workhorse socket
Set some timeouts and proxify gitlab-workhorse upstream Not sure if needed, but I think that's safer. As alternative, instead of create a new location we can just override the proxy_pass definition of location @GitLab (line 18).
|
Thanks for the submission. @qrntz I know you are busy, but when you get a chance can you please have a look over this. |
|
OK. |
|
Can be closed in favor of #17 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve turnkeylinux/tracker#686 (can't open issue on this repo)
Fetch and make gitlab-workhorse to complete all the Gitlab dependencies.
gitlab-workhorse is expected by the Gitlab startup process (see /etc/init.d/gitlab), additionally HTTP requests are optimized and avoid some errors related to HTTP operations through git client (i.e https://gitlab.com/gitlab-org/gitlab-ce/issues/2669#note_2176671)
This PR
0) Add GO as a dependency (make gitlab-workhorse)
Among other things, issues like "empty repo" at "git clone http://XXXX" will be solved.