16.0 update #29
Merged
16.0 update #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnGle
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
This all looks good, bar the apt-key stuff, which as I have written up on syncthing I believe your tests have not yet conclusively proven is operating as you have stated and suggest we postpone merging until my additional suggested tests have been performed.
|
As per my note on syncthing, I'll merge this. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for v16.0; mostly just python3 updates.
@OnGle - I used the apt-key method on this one too, although as per my comment on Syncthing, I have checked and it works as I thought (i.e. key only written to keyfile in
/usr/share/keyrings/).