Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up inithooks #42

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

JedMeister
Copy link
Member

@JedMeister JedMeister commented Dec 17, 2024

firstboot.d bash inithook updates:

  • apply shellcheck fixes
  • remove redundant comments & code
  • improve readability
  • other minor tweaks

bin python inithook update:

  • add missing schema to cli options (included in help, but not in getopt options)
  • GL password setting output as string (not binary string)
  • GL password setting output to relevant stream - i.e. error to stderr

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@JedMeister JedMeister changed the title Clean up firstboot inithooks Clean up inithooks Dec 17, 2024
@JedMeister JedMeister requested a review from OnGle February 18, 2025 08:19
Copy link
Contributor

@OnGle OnGle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

(Big 👍 for replacing some ternary control flow with an if statement)

@JedMeister JedMeister merged commit 5cbc295 into turnkeylinux-apps:master Feb 19, 2025
@JedMeister JedMeister deleted the inithook-tweak branch February 19, 2025 02:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants