-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix/queue breaks on failure #92
Fix/queue breaks on failure #92
Conversation
Hey @hannojg thanks for this PR - just like the other, should have time to review tomorrow! Thanks for making so many contributions! |
Great! I just fixed another issue (in 9e59405) where the queue would hang up in (just also noticed that this happens when the request e.g. times out, so its very useful to have this handling in place 😄 ) |
…nd continue if so)
Fixed another issue where it wasn't checking correctly when an upload has failed whether we should continue uploading in respect to the background (mode) execution. |
What this PR fixes
When integrating the TUSKit into our app we realised that our TUS-Server was not configured correctly. The
create
method failed. This broke the queue as it hasn't been marked as.ready
again.Changes introduced to fix this:
TUSUploadStatus
has now a new value calledfailed
TUSClient
has a new function calledpendingUploads()
which returns allcurrentUploads
filtered by any failed uploads. This function is used where we check for e.g. the next uploadTUSExecutor
whencreate
failscancel
is called withfailed: true
which marks the upload as failedExample app
: Only callresumeAll
when the user hasn't selected any files