-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
n-message hover will not destroyed (#1036) #1039
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tusimple/naive-ui/HNeXWH8ZYxdqsKVgzEMN4n8WLKen |
Codecov Report
@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
- Coverage 47.36% 47.35% -0.02%
==========================================
Files 511 511
Lines 12628 12633 +5
Branches 3557 3559 +2
==========================================
+ Hits 5981 5982 +1
- Misses 5633 5636 +3
- Partials 1014 1015 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This should be a optional feature. Add
keepAliveOnHover
onn-message-provider
and message option. - Duration shouldn't be recaculate after mouse leave.
I don’t agree with the second point. I refer to |
Okay, just implement the firsrt |
3657e11
to
5eca175
Compare
@@ -2,7 +2,7 @@ | |||
|
|||
```html | |||
<n-space> | |||
<n-button @click="info"> 信息 </n-button> | |||
<n-button @click="info"> 信息(Hover不消失)</n-button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<n-button @click="info"> 信息(Hover不消失)</n-button> | |
<n-button @click="info"> 信息(Hover 不消失)</n-button> |
onMouseenter={this.onMouseenter} | ||
onMouseleave={this.onMouseleave} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这事件会冒泡的,事件处理器要注意这种情况
close #1036