Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(loading-bar): disappears unexpectly #347

Merged
merged 2 commits into from
Jul 1, 2021
Merged

fix(loading-bar): disappears unexpectly #347

merged 2 commits into from
Jul 1, 2021

Conversation

07akioni
Copy link
Collaborator

@07akioni 07akioni commented Jul 1, 2021

fix #343

@07akioni 07akioni temporarily deployed to test July 1, 2021 15:40 Inactive
@07akioni 07akioni temporarily deployed to test July 1, 2021 15:40 Inactive
@vercel
Copy link

vercel bot commented Jul 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/H2knM2E6PW3Xq9yE6E7NhgWcHigY
✅ Preview: https://naive-ui-git-fix-loadingbar-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #347 (550a7a2) into main (0442b4f) will increase coverage by 0.40%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   33.31%   33.71%   +0.40%     
==========================================
  Files         507      507              
  Lines       12080    12085       +5     
  Branches     3297     3298       +1     
==========================================
+ Hits         4024     4075      +51     
+ Misses       7305     7234      -71     
- Partials      751      776      +25     
Impacted Files Coverage Δ
src/loading-bar/src/LoadingBar.tsx 20.83% <16.66%> (+0.54%) ⬆️
src/_internal/select-menu/src/SelectMenu.tsx 40.90% <0.00%> (+3.63%) ⬆️
src/_internal/selection/src/Selection.tsx 30.27% <0.00%> (+7.31%) ⬆️
src/select/src/Select.tsx 34.09% <0.00%> (+10.34%) ⬆️
src/_internal/select-menu/src/SelectOption.tsx 58.97% <0.00%> (+12.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0442b4f...550a7a2. Read the comment docs.

@07akioni 07akioni merged commit 1a35408 into main Jul 1, 2021
@07akioni 07akioni deleted the fix-loadingbar branch July 1, 2021 15:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoadingBar auto finish
1 participant