Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(tabs): add indicator arrows supports scrolling operation #628

Closed
wants to merge 4 commits into from

Conversation

kev1nzh37
Copy link
Collaborator

@vercel
Copy link

vercel bot commented Jul 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/EnugihqprJg7yUMcS6preyg9fVAJ
✅ Preview: https://naive-ui-git-fork-kev1nzh37-feature-tabs-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #628 (5d310d7) into main (9d2a9d8) will increase coverage by 0.16%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   38.93%   39.09%   +0.16%     
==========================================
  Files         507      507              
  Lines       12302    12328      +26     
  Branches     3425     3433       +8     
==========================================
+ Hits         4790     4820      +30     
+ Misses       6605     6594      -11     
- Partials      907      914       +7     
Impacted Files Coverage Δ
src/tabs/src/Tabs.tsx 45.94% <23.07%> (+10.09%) ⬆️
src/tabs/src/Tab.tsx 30.76% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d2a9d8...5d310d7. Read the comment docs.

@07akioni
Copy link
Collaborator

我是在想这个箭头的必要性,总觉得不一定是必须加的,这些浏览器的 tabs 也没有哪个多了之后就提供箭头了

@kev1nzh37
Copy link
Collaborator Author

浏览器的tab页应该除了safari都是默认左侧排列(超出宽度时会自适应并不会出现滚动条)。开发之前参考了几个ui库,有的组件库以箭头来提供滚动操作,有的组件库以右侧dropdown提供操作,或许右侧dropdown的处理会比较合适。

平时开发用触控板,碰到遇上有滚动条的tabs时一滑就能滚动到想要的tab,而windows端的浏览器上,我会第一时间不知道如何操作,接着才会想起用鼠标滚动键来操作。

@pengxiaotian
Copy link
Contributor

什么时候 mege?

@07akioni
Copy link
Collaborator

07akioni commented Sep 4, 2021

什么时候 mege?

在我找到一个看起来足够习惯的样式时

@07akioni
Copy link
Collaborator

07akioni commented Jan 8, 2022

wont do, ref #2128 (comment)

@07akioni 07akioni closed this Jan 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants