-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(tabs): add indicator arrows supports scrolling operation #628
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tusimple/naive-ui/EnugihqprJg7yUMcS6preyg9fVAJ |
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
==========================================
+ Coverage 38.93% 39.09% +0.16%
==========================================
Files 507 507
Lines 12302 12328 +26
Branches 3425 3433 +8
==========================================
+ Hits 4790 4820 +30
+ Misses 6605 6594 -11
- Partials 907 914 +7
Continue to review full report at Codecov.
|
我是在想这个箭头的必要性,总觉得不一定是必须加的,这些浏览器的 tabs 也没有哪个多了之后就提供箭头了 |
浏览器的tab页应该除了safari都是默认左侧排列(超出宽度时会自适应并不会出现滚动条)。开发之前参考了几个ui库,有的组件库以箭头来提供滚动操作,有的组件库以右侧dropdown提供操作,或许右侧dropdown的处理会比较合适。 平时开发用触控板,碰到遇上有滚动条的tabs时一滑就能滚动到想要的tab,而windows端的浏览器上,我会第一时间不知道如何操作,接着才会想起用鼠标滚动键来操作。 |
什么时候 mege? |
在我找到一个看起来足够习惯的样式时 |
wont do, ref #2128 (comment) |
#440