-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Port v4 browser support table format to v3 #19273
Port v4 browser support table format to v3 #19273
Conversation
<td class="text-muted">N/A</td> | ||
<td class="text-success"><span class="glyphicon glyphicon-ok" aria-hidden="true"></span> Supported</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should read "Android v5.0+ supported" to match v4
If we're going to claim support for Edge, then we should add Edge to v3's Sauce testing config. I slightly question adding the "feature" of AndroidBrowser+Edge+Win10Mobile official support this late in v3's lifecycle though. |
Fair enough about not adding new browser combos. As an alternative, then, how about just porting the top/tail text, split into mobile/desktop, but leave actual table content unchanged? |
Updated table layout and more granular text is a-okay by me. I'd rather not sign us up for more/new browser combos as @cvrebert mentioned :). |
👍 |
rejigged the PR - this now ports the overall formatting, splitting the support table into separate mobile/desktop, but does not add any new browser combos (although I did add Microsoft Edge under the "Unofficially..." section, as from my experience it seems to all work fairly well there). Also, as Opera now falls under the "Alternative browsers which use the latest version of WebKit, Blink, or Gecko," bit, I removed it from the tables as well. For a quick look of the end result of this, see http://www.bootply.com/oFgjmGsVGX |
Port v4 browser support table format to v3
Port of #18614 from v4 to v3
Ref #19269