Fix/xss issues on data attributes #27047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don-spyker
force-pushed
the
fix/xss-issues-on-data-attributes
branch
from
5fd1134
to
ae29b6a
Compare
Closed
Johann-S
reviewed
Aug 10, 2018
| @@ -16,7 +16,9 @@ | |||
| var Affix = function (element, options) { | |||
| this.options = $.extend({}, Affix.DEFAULTS, options) | |||
|
|
|||
| this.$target = $(this.options.target) | |||
| var target = this.options.target === Affix.DEFAULTS.target ? $(this.options.target) : $(document).find(this.options.target) | |||
There was a problem hiding this comment.
There is no need for your ternary here: $(document).find(this.options.target) is enough
There was a problem hiding this comment.
I tried that first, but that broke the functionality as the default is "window" and
Johann-S
requested changes
Aug 10, 2018
This was referenced Sep 17, 2020
This was referenced Nov 9, 2020
This was referenced Nov 16, 2020
1 task
This was referenced Feb 26, 2023
This was referenced Apr 26, 2023
This was referenced Jul 10, 2023
36 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix of xss issues that have been fixed in v4.x already + fix of two additional xss issues
Fixes #26625 / CVE-2018-14040
Fixes #26628 / CVE-2018-14042
Fixes #27044 / CVE-2018-20676
Fixes #27045 / CVE-2018-20677