Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Use param to set Bootstrap version in Contents page #35556

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 16, 2021

This PR proposes to use the docs_version param in the Getting Started > Contents documentation to avoid to forget update it after a change of version.

Note: could be done in the v4-dev branch as well if approved.

Preview: https://deploy-preview-35556--twbs-bootstrap.netlify.app/docs/5.1/getting-started/contents/#bootstrap-source-code

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, how did we miss that?
Thanks!

@XhmikosR
Copy link
Member

Because when I first made the switch to Hugo param wasn't even a thing 😛

Thanks!

@XhmikosR XhmikosR changed the title Use param to set Bootstrap version in Contents doc docs: Use param to set Bootstrap version in Contents page Dec 16, 2021
@XhmikosR XhmikosR merged commit 2d07383 into twbs:main Dec 16, 2021
@julien-deramond julien-deramond deleted the main-jd-dynamic-version-in-contents branch December 16, 2021 08:21
XhmikosR added a commit that referenced this pull request Dec 16, 2021
* Use param to set Bootstrap version in Contents doc

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants