Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

v4: Improve accessible name of version dropdown in docs navbar #36504

Merged
merged 3 commits into from
Jun 5, 2022
Merged

v4: Improve accessible name of version dropdown in docs navbar #36504

merged 3 commits into from
Jun 5, 2022

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Jun 4, 2022 •
edited
Loading

  • add sr-only "Bootstrap", which will be part of the accessible name
  • extra sr-only text to give some context - that the dropdown is about switching versions
  • remove the redundant id/aria-labelledby for the dropdown
  • change the control from <a> to <button>

v4 port (and further tweaks) of #36495

@patrickhlauke
Improve accessible name of version dropdown in docs navbar
dde6406 
- add separate visually-hidden "Bootstrap", which will be part of the accessible name regardless of whether the other string is visible or not (on large screen)
- extra visually-hidden text to give some context - that the dropdown is about switching versions
- remove the redundant id/aria-labelledby for the dropdown
@patrickhlauke patrickhlauke changed the title Improve accessible name of version dropdown in docs navbar v4: Improve accessible name of version dropdown in docs navbar Jun 4, 2022
@patrickhlauke
Copy link
Member Author

snuck in a last addition ... changing the control from <a> to <button> (though this does show one issue with the focus indication being very weak for buttons in the header...but will tackle this another time)

@patrickhlauke patrickhlauke force-pushed the patrickhlauke-improve-docs-navbar-version-dropdown-v4 branch from 3b7c33d to 13baad1 Compare June 5, 2022 09:17
@patrickhlauke patrickhlauke force-pushed the patrickhlauke-improve-docs-navbar-version-dropdown-v4 branch from 13baad1 to 5d3330e Compare June 5, 2022 09:24
@patrickhlauke patrickhlauke merged commit 6fd2030 into v4-dev Jun 5, 2022
@patrickhlauke patrickhlauke deleted the patrickhlauke-improve-docs-navbar-version-dropdown-v4 branch June 5, 2022 09:33
@RohitM-IN RohitM-IN mentioned this pull request May 19, 2024
Open
@humanbot humanbot mentioned this pull request May 20, 2024
Open
@saurabharch saurabharch mentioned this pull request May 20, 2024
Open
@h-gj h-gj mentioned this pull request May 21, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 22, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request May 22, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 23, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request May 24, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 24, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request May 24, 2024
Open
@ryanwittmers ryanwittmers mentioned this pull request May 24, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request May 25, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 25, 2024
Open
@angelika-draczynska angelika-draczynska mentioned this pull request May 26, 2024
Open
@gaetanBloch gaetanBloch mentioned this pull request Sep 21, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 21, 2024
Open
@ryanwittmers ryanwittmers mentioned this pull request Sep 21, 2024
Open
@tiff-es tiff-es mentioned this pull request Sep 22, 2024
Open
@blakegreendev blakegreendev mentioned this pull request Sep 22, 2024
Open
@DinGo4DEV DinGo4DEV mentioned this pull request Sep 22, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 22, 2024
Open
@TheAutisticTechie TheAutisticTechie mentioned this pull request Sep 22, 2024
Open
@gaetanBloch gaetanBloch mentioned this pull request Sep 23, 2024
Open
This was referenced Sep 23, 2024
Open
Open
Open
Open
Open
Open
Open
@imsureshbala imsureshbala mentioned this pull request Sep 29, 2024
Open
This was referenced Sep 30, 2024
Open
Open
Open
Open
This was referenced Oct 4, 2024
Open
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 4, 2024
Open
@saadi1995 saadi1995 mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 30, 2024
Open
@snyk-kevin snyk-kevin mentioned this pull request Nov 3, 2024
Open
@leopard1982 leopard1982 mentioned this pull request Nov 3, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Nov 6, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
docs v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickhlauke @julien-deramond