Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Docs: Better scroll #38199

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Docs: Better scroll #38199

merged 1 commit into from
Mar 10, 2023

Conversation

louismaximepiton
Copy link
Member

Description

Removing :focus.
Removing * and replacing it by more specific selector.
Adding a scroll-margin-bottom.

Motivation & Context

Didn't work on FF.
Performance issue using the universal selector.
Avoid sticking to the very bottom of the page.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (NA) My change introduces changes to the documentation
  • (NA) I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@louismaximepiton louismaximepiton requested a review from a team as a code owner March 8, 2023 14:04
@louismaximepiton louismaximepiton mentioned this pull request Mar 8, 2023
Merged
21 tasks
@mdo mdo merged commit 1f7e7eb into main Mar 10, 2023
@mdo mdo deleted the main-lmp-better-docs-focus branch March 10, 2023 17:15
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
This was referenced May 19, 2024
Open
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
This was referenced May 24, 2024
Open
Open
@devcurt696 devcurt696 mentioned this pull request May 24, 2024
Open
@suryaelidanto suryaelidanto mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Guiguiiz92 Guiguiiz92 mentioned this pull request May 24, 2024
Open
@Cpano Cpano mentioned this pull request May 24, 2024
Open
@zxcv32 zxcv32 mentioned this pull request May 24, 2024
Open
@rawanst rawanst mentioned this pull request May 24, 2024
Open
@V1CTORY360 V1CTORY360 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@ngochoangg ngochoangg mentioned this pull request May 24, 2024
Open
@jadsongmatos jadsongmatos mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
This was referenced Aug 26, 2024
Open
Open
@tchellam tchellam mentioned this pull request Aug 27, 2024
Open
@sophakphol sophakphol mentioned this pull request Aug 29, 2024
Open
@csmartinez22 csmartinez22 mentioned this pull request Aug 30, 2024
Open
@ungtsuhan ungtsuhan mentioned this pull request Aug 30, 2024
Open
This was referenced Sep 3, 2024
Open
Open
Open
@IngageDigitalAgency IngageDigitalAgency mentioned this pull request Sep 7, 2024
Open
@thanhdt24 thanhdt24 mentioned this pull request Sep 7, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Sep 8, 2024
Open
@arlindo0x73 arlindo0x73 mentioned this pull request Sep 8, 2024
Open
@AndresElacion AndresElacion mentioned this pull request Sep 24, 2024
Open
@castle2668 castle2668 mentioned this pull request Sep 24, 2024
Merged
This was referenced Sep 25, 2024
Open
Open
Open
@pinco227 pinco227 mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 28, 2024
Open
Open
@lisagorewitdecker lisagorewitdecker mentioned this pull request Sep 30, 2024
Merged
This was referenced Sep 30, 2024
Open
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
docs enhancement v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @mdo