Frontend Rework - Switch from serde_cyclonedx to cyclonedx-bom #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinvanderVeen
changed the title
ErinvanderVeen
force-pushed
the
40-consider-switching-from-serde_cyclonedx-to-cyclonedx-sbom
branch
from
f6fce78 to
3a1f759
Compare
ErinvanderVeen
force-pushed
the
40-consider-switching-from-serde_cyclonedx-to-cyclonedx-sbom
branch
2 times, most recently
from
0749f90 to
ac28a8b
Compare
ErinvanderVeen
force-pushed
the
40-consider-switching-from-serde_cyclonedx-to-cyclonedx-sbom
branch
from
ac28a8b to
d869e03
Compare
yannham
approved these changes
Mar 25, 2024
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend Rework - Switch from serde_cyclonedx to cyclonedx-bom
Issue: #40
NOTE: CycloneDX/cyclonedx-rust-cargo#584 starts support for v1.5.
Once upstream fully implements 1.5 we need to re-implement it in our crate.
For now, we merge this PR looking forward to the future.
Description
This PR completely reworks Genealogos' frontend (called
bominternally). Similar to theBackendandBackendHandle, there is now aBomtrait that is responsible for the generation of the bom.Checklist
Checklist before merging: